fix(avro): include headers used by file batch reader#422
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes AvroFileBatchReader header self-containment by adding direct includes for types/functions used in the header’s inline implementation.
Changes:
- Add
<limits>to supportstd::numeric_limits<uint64_t>::max()used in inline method/member initializers. - Add
fmt/format.hto supportfmt::format(...)used in the inlineGetPreviousBatchFileRowIdimplementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Thank you, @zjw1111! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
Fix
AvroFileBatchReaderheader self-containment by including the headers used by its inlineGetPreviousBatchFileRowIdimplementation.Tests
cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DPAIMON_BUILD_TESTS=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5src/paimon/format/avro/avro_file_batch_reader.cppusing the generated compile command plus local fmt/Arrow source include pathsgit diff --checkNot run:
cmake --build build --target paimon_avro_file_format_objlib -j8was blocked by bundled Arrow dependency download failure: Apache Thrift 0.16.0 mirror URLs returned 404.pre-commit run --files src/paimon/format/avro/avro_file_batch_reader.hwas not run becausepre-commitis not installed in this environment.API and Format
No public API, storage format, or protocol changes.
Documentation
No user-facing feature or documentation changes.
Generative AI tooling
Generated-by: OpenAI Codex